Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove counter_payout from RenewOffer #149

Open
luckysori opened this issue Sep 7, 2023 · 0 comments
Open

Remove counter_payout from RenewOffer #149

luckysori opened this issue Sep 7, 2023 · 0 comments
Labels
channel Related to DLC channels

Comments

@luckysori
Copy link
Collaborator

The counterparty payout for the Contract that is being replaced by the renew protocol can be computed by calculating the difference between the collateral of the to-be-replaced Contract and the ContractInput in the RenewOffer. This value can then be used to compute the implicit PNL of the replaced Contract.

As such we don't need/want to keep around the extra counter_payout argument and field throughout the renew protocol.
@luckysori luckysori added the channel Related to DLC channels label Sep 7, 2023
@luckysori luckysori added this to LN-DLC Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
channel Related to DLC channels
Projects
LN-DLC
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@luckysori