Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Works only with n_feats=80 #26

Open
patriotyk opened this issue Feb 8, 2024 · 6 comments
Open

Works only with n_feats=80 #26

patriotyk opened this issue Feb 8, 2024 · 6 comments

Comments

@patriotyk
Copy link

I have tried to change n_feats=100 and train, but looks like there is several places hardcoded for 80 because I got crashes that say it expects size 80.

@p0p4k
Copy link
Owner

p0p4k commented Feb 8, 2024

Yes, manually replace 80 with 100. There are different modules giving out 80 sized outputs, they can be further edited to change their output sizes, so better to change it to 80 wherever needed. In my another encodec branch, it gives out 128 feats, you can use it for reference.

@patriotyk
Copy link
Author

Thank you!!!

@lumpidu
Copy link

lumpidu commented Feb 15, 2024

Could you elaborate, when it would be useful to increase the n_feats setting ?

@patriotyk
Copy link
Author

It depends on vocoder. So if you have vocoder trained with 100 features, pflow model also should generate mels with 100 features.

@lumpidu
Copy link

lumpidu commented Feb 17, 2024

Ok, understood. But I would like to know more about the intuition behind changing those parameters: do you want to increase the quality, the frequency resolution, or e.g. by reducing the parameter, inference speed ?

@patriotyk
Copy link
Author

In my case I just wanted to try pflow with pretrained vocos vocoder. I just wanted to compare it with pretrained hifigan. I suppose it should sound better but I don't know for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants