Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better chapter title handling #47

Open
p0n1 opened this issue Feb 20, 2024 · 5 comments
Open

Better chapter title handling #47

p0n1 opened this issue Feb 20, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@p0n1
Copy link
Owner

p0n1 commented Feb 20, 2024

I'm a bit concerned about the possibility that items labeled as h1 h2 h3 could be non section title. However, it's not a big issue, and if there is indeed a problem, we can fix it later.

Originally posted by @p0n1 in #30 (comment)

I ran into a book with single numbers in h1 tag. So, the chapter titles would be just something like 01, 02... I prefer to keep more context/strings in title so I can know more about each chapter audio file.

@p0n1 p0n1 added the enhancement New feature or request label Feb 20, 2024
@p0n1 p0n1 self-assigned this Feb 20, 2024
@GamerClassN7
Copy link

in my case chapters are in 2 lines, would be possible to parse both lines
not just "DVA" ?

image

@GamerClassN7
Copy link

also in my case Audio-bookshelf detect correct order of chapters but, conversion container i scrambling the order.
For example upper mentioned book is scrambled in order

0 chaper 1
2 prolong chapter 0
2 chapter 5

Could this be due to script not parsing full chapter names ?

@GamerClassN7
Copy link

also in my case Audio-bookshelf detect correct order of chapters but, conversion container i scrambling the order. For example upper mentioned book is scrambled in order

0 chaper 1 2 prolong chapter 0 2 chapter 5

Could this be due to script not parsing full chapter names ?

posibbly bound exactly same error
aerkalov/ebooklib#149

self.book.get_items_of_type(ebooklib.ITEM_DOCUMENT)] do not return chapters in correct order thy need to be sorted somehow

@GamerClassN7
Copy link

GamerClassN7 commented Mar 20, 2024

@p0n1 Sorry for the ping but would be possible to add some preview of chaperd in order thy will be generated ? i dont know if it affect only my language but every time i generate book in my language chapters are in incorrect order.
it is probably also connected to this: #57

@GamerClassN7
Copy link

GamerClassN7 commented Jul 1, 2024

@p0n1 Sorry for the ping but would be possible to add some preview of chaperd in order thy will be generated ? i dont know if it affect only my language but every time i generate book in my language chapters are in incorrect order.
it is probably also connected to this: #57

Hi @p0n1, Any news on better handling of chapter order most of book I converted, need to be sorted manually after generation and come of them have more than 30 files, sorting order of books by spine part of EPUB would be good addition, not just for me but for everyone:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants