Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mg-ddm appears to emit both plaintext and bunyan-format logs #350

Open
davepacheco opened this issue Aug 27, 2024 · 1 comment
Open

mg-ddm appears to emit both plaintext and bunyan-format logs #350

davepacheco opened this issue Aug 27, 2024 · 1 comment

Comments

@davepacheco
Copy link

Elsewhere we use bunyan-format logs, which are JSON entries that looker can read. In some places (some dev tools) we have configured slog to emit a plaintext format. mg-ddm appears to do both of these. Here's a snippet from a file:

{"msg":"[vioif2] removing 0 routes from illumos","v":0,"name":"slog-rs","level":30,"time":"2024-08-27T17:18:48.458201847Z","hostname":"g3","pid":1339}
Aug 27 17:23:04.670 DEBG client request, body: Some(Body), uri: http://[fd00:1122:3344:102::5]:12221/metrics/producers, method: POST, component: producer-registration-task

The plaintext output makes it much harder to do things like filtering on log level with looker.

@rcgoodfellow
Copy link
Collaborator

rcgoodfellow commented Aug 27, 2024

Yeah I think the omicron/oximiter logging is colliding with normal maghemite logging. Will look into this. Maghemite does use bunyan-format logs and I use looker with it a lot. But it seems something has gone sideways with recent integrations that do their own logging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants