Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return the max challenges if min and max tez are equal #5

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Return the max challenges if min and max tez are equal #5

merged 3 commits into from
Oct 6, 2023

Conversation

harryttd
Copy link
Contributor

@harryttd harryttd commented Oct 6, 2023 •
edited
Loading

  • Fixes a bug where NaN would be returned for challengesNeeded if min and max tez are equal. We now return the max challenges.
  • Validate challenge args before saving to redis
  • Add clearer error message if faucet is low or empty

@harryttd harryttd self-assigned this Oct 6, 2023
@harryttd harryttd merged commit 8d3703c into main Oct 6, 2023
2 checks passed
@harryttd harryttd deleted the updates branch October 6, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasochem nicolasochem nicolasochem approved these changes

Assignees

@harryttd harryttd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harryttd @nicolasochem