Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of package code #52

Open
MJHutchinson opened this issue Oct 22, 2020 · 0 comments
Open

Refactor of package code #52

MJHutchinson opened this issue Oct 22, 2020 · 0 comments
Milestone

Comments

@MJHutchinson
Copy link
Contributor

Currently, the code in the mapping and cleaning packages is intimately tied to the specific data we have. This will need to be cleanly separated for use to a) do the simulation tests and b) release the code for general use.

The main suggestion would be to depreciate the use of environments in package functions and have them take explicit arguments instead. The use of environments can still remain in our loading code, but using them as function arguments make code very opaque and unclear what a function needs in the env to work.

@ywteh ywteh added this to the phase1 milestone Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants