You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason to change the format of the smashbox.conf.template is because the generator needs more information about the variables. The more important information is if the variable needs to be changed, and other information might be a help text, optional type conversion, etc.
In addition If I need to compile and exec the file to load the information.... I don't think it's a good idea.
I had to create a new config key (_configgen) to manage the configuration of the generator. It's currently bloated, from my point of view, because of the lack of information of the keys, so all the information missing has been added there.
The other file is the key-value-file.json.sample. It's json format which seems misplaced in the code, but it has advantages over a plain key=value file.
From my point of view, we have a couple of possibilities:
The first one, use a proper python file that can be easily imported as any other module, something like config_base.py
The second option is to use a json or yaml format to hold the same information as shown above. Probably json isn't a good choice since it doesn't support comments
Regardless of the format the advantage is an extensible content (new keys as well as more data regarding the keys can be easily added without any disturbance).
Anyway, the output file (the smashbox.conf) will remain the same, at least in the short term
Working tree for the config generator: https://github.com/owncloud/smashbox/tree/config_generator
The files are:
The reason to change the format of the smashbox.conf.template is because the generator needs more information about the variables. The more important information is if the variable needs to be changed, and other information might be a help text, optional type conversion, etc.
In addition If I need to compile and exec the file to load the information.... I don't think it's a good idea.
I had to create a new config key (_configgen) to manage the configuration of the generator. It's currently bloated, from my point of view, because of the lack of information of the keys, so all the information missing has been added there.
The other file is the key-value-file.json.sample. It's json format which seems misplaced in the code, but it has advantages over a plain key=value file.
From my point of view, we have a couple of possibilities:
The first one, use a proper python file that can be easily imported as any other module, something like config_base.py
The second option is to use a json or yaml format to hold the same information as shown above. Probably json isn't a good choice since it doesn't support comments
Regardless of the format the advantage is an extensible content (new keys as well as more data regarding the keys can be easily added without any disturbance).
Anyway, the output file (the smashbox.conf) will remain the same, at least in the short term
@nickvergessen @PVince81
The text was updated successfully, but these errors were encountered: