Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request should return Promise.reject when response code is not 2xx #24

Open
georgehrke opened this issue Sep 20, 2016 · 1 comment
Open

Request should return Promise.reject when response code is not 2xx #24

georgehrke opened this issue Sep 20, 2016 · 1 comment

Comments

@georgehrke
Copy link
Contributor

Right now the developer has to check if the request was successful in the then "block".
It would be easier for developers, if instead of resolving, davclient.js would automatically reject the promise if the response code is not a 2xx one.
@PVince81
Copy link
Contributor

Indeed. I was also confused by this for a while until I remembered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PVince81 @georgehrke