Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests for etag propagation #20521

Closed
PVince81 opened this issue Nov 16, 2015 · 7 comments
Closed

Integration tests for etag propagation #20521

PVince81 opened this issue Nov 16, 2015 · 7 comments
Assignees
Milestone

Comments

@PVince81
Copy link
Contributor

Currently there are unit tests for etag propagation, but it would be good to have these on Webdav level as well.

Basically fire up a Webdav client (Sabre client?), setup shares, reshares, modify a file/folder and then check whether the etag of owner and all recipients and reshare recipients has changed or stayed the same.

There is a list of unit tests that could be used for reference: https://github.com/owncloud/core/blob/master/apps/files_sharing/tests/etagpropagation.php#L184 and also the test plans #14764 (comment) and #14764 (comment).
Not only the root of the user's etag must change but also every parent folder that lead to the changed folder/share.

@DeepDiver1975 @icewind1991 @SergioBertolinSG

CC @rperezb

@PVince81
Copy link
Contributor Author

@SergioBertolinSG let us know if you have questions about the cases, I know it's not trivial 😄

@DeepDiver1975
Copy link
Member

Is this something we shall implement using smashbox?

@PVince81
Copy link
Contributor Author

I thought the integration tests were already using a Webdav client to test OCS ? Might as well do the same for this.

With smashbox, using the sync client to detect etag changes (and non-etag changes) is more tricky, especially need to detect non-redownloads when the etag did not change. The only approach, even in smashbox, would be to use only pyocclient to directly check the etag in the Webdav responses.

So, both are possible. Not sure which one is best.

@SergioBertolinSG
Copy link
Contributor

@DeepDiver1975 This is the same request you were talking about in #20397 (comment) ?

@PVince81
Copy link
Contributor Author

Let's do smashbox with pyocclient then

@PVince81
Copy link
Contributor Author

The tests are here owncloud/smashbox#136

@PVince81 PVince81 closed this as completed Feb 8, 2016
@lock
Copy link

lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants