Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy propagate etags to all users except current one #15910

Closed
PVince81 opened this issue Apr 28, 2015 · 5 comments
Closed

Lazy propagate etags to all users except current one #15910

PVince81 opened this issue Apr 28, 2015 · 5 comments

Comments

@PVince81
Copy link
Contributor

This PR #14764 introduces lazy etag propagation.
But in some cases it still updates the etag of other users who are not the current one (ex: owner).

To reduce the number of cache updates, we should make sure that the etag propagation is only done for the currently logged in user (the one who performed an action), and lazily do it for other users.

This came to mind after getting feedback from @butonic regarding excessive PostgreSQL cache updates.

@icewind1991

@PVince81
Copy link
Contributor Author

There is a test plan here: #14764 (comment)
If you monitor the DB changes, you can notice that in some cases the etag is changed directly (non-lazily) for more than a user.

@guruz
Copy link
Contributor

guruz commented Oct 29, 2015

Sounds smart!

@PVince81 PVince81 added this to the backlog milestone Mar 2, 2016
@PVince81
Copy link
Contributor Author

PVince81 commented Mar 2, 2016

@icewind1991 I guess this is obsolete thanks to the new "storage-only etag propagation" + "compute etag of all mounted storages" logic ?

@icewind1991
Copy link
Contributor

Yes

@lock
Copy link

lock bot commented Aug 5, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants