Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Owl_plplot can't set device/driver independently of filename suffix #572

Open
ComposMin opened this issue Jan 24, 2021 · 1 comment
Open
Assignees

Comments

@ComposMin
Copy link

ComposMin commented Jan 24, 2021

The function _set_device infers which Plplot device/driver to set based on the suffix of the output file. This makes it awkward to use the pdfcairo, pngcairo drivers - as you must use this as the suffix to generate the graph, but then usually need to rename the file to have other standard tools interact with the file.

https://github.com/owlbarn/owl/blob/master/src/plplot/owl_plot.ml#L419-L425

I'm happy to contribute a code fix, but wondered if you have any specific guidance on the shape of the fix, so that it doesn't break existing code.

@ComposMin
Copy link
Author

Making use of the Cairo drivers makes it easier to use Owl_plplot running in Jupyter notebooks environments that use Docker (without X11 dependencies).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants