Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude entities without data for any year from the entity selector #4263

Open
sophiamersmann opened this issue Dec 6, 2024 · 1 comment

Comments

@sophiamersmann
Copy link
Member

See #3492 for an example, but this is a wider issue that probably happens for most chart types.

We might want to rethink how the entity selector table is constructed. Currently we run transformations of a chart's transformTableForSelection on the input table (except for scatters). This is cumbersome and error-prone. We could try restructuring the tables and transforms such that the entity selector gets the transformed table before entity and time filtering. Of course this would mean that we run (potentially) perf-draining transforms on the unfiltered input table.

@marcelgerber
Copy link
Member

marcelgerber commented Dec 9, 2024

A bit more context on this:
Currently, for many chart types, common first transforms to run on a table are filtering by selected entities, and filtering to the current timeline selection.

The main advantage of this is that the coming transforms may then run on way fewer rows of data. Which can be beneficial, because some transforms like tolerance are quite costly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants