-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --status-codes, --exclude-codes flag #406
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
📑 documentation
Improvements or additions to documentation
📦 output-builder
Issue for output builder (format)
⚙️ options
Issue for options (flag)
⛱️ config
Issue for Configuration
labels
Sep 21, 2024
…new default option
ksg97031
force-pushed
the
feature/endpoint-status-codes
branch
from
September 21, 2024 19:46
9130a61
to
233b5fc
Compare
ksg97031
changed the title
Add --show-status flag
Add --show-status, --exclude-status flag
Sep 21, 2024
ksg97031
changed the title
Add --show-status, --exclude-status flag
Add --status-code, --exclude-codes flag
Sep 22, 2024
ksg97031
changed the title
Add --status-code, --exclude-codes flag
Add --status-codes, --exclude-codes flag
Sep 22, 2024
ksg97031
force-pushed
the
feature/endpoint-status-codes
branch
from
September 22, 2024 05:52
7fab325
to
18e9620
Compare
ksg97031
commented
Sep 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Color:
- 1xx: light_green
- 2xx: light_green
- 3xx: cyan (yellow is already used for endpoint URLs)
- 4xx: light_red
- 5xx: light_magenta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
⛱️ config
Issue for Configuration
📑 documentation
Improvements or additions to documentation
⚙️ options
Issue for options (flag)
📦 output-builder
Issue for output builder (format)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve: #397
Examples
Command 1:
$ crystal run src/noir.cr -- -b ../spring-demo -u http://172.30.1.15:8080 --status-codes
Command 2:
$ crystal run src/noir.cr -- -b ../spring-demo -u http://172.30.1.15:8080 --exclude-codes 400
Error Cases
Without URL option:
$ crystal run src/noir.cr -- -b ../spring-demo --status-codes
$ crystal run src/noir.cr -- -b ../spring-demo --exclude-codes
Invalid exclude codes:
$ crystal run src/noir.cr -- -b ../spring-demo -u http://172.30.1.15:8080 --exclude-codes aaa
Server doesn't respond:
$ crystal run src/noir.cr -- -b ../spring-demo -u http://127.0.0.1:8081 --status-codes