feat(pci.private-network): Listing page - Listing page revamp #14210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref: -1826 Signed-off-by: tsiorifamonjena <[email protected]>
Tsiorifamonjena
requested review from
sidlynx,
seven-amid,
MaximeBajeux,
ghyenne and
sachinrameshn
and removed request for
a team
ref: -1826 Signed-off-by: tsiorifamonjena <[email protected]>
ref: -1826 Signed-off-by: tsiorifamonjena <[email protected]>
ref: -1826 Signed-off-by: tsiorifamonjena <[email protected]>
ref: -1826 Signed-off-by: tsiorifamonjena <[email protected]>
ref: -1826 Signed-off-by: tsiorifamonjena <[email protected]>
Comment on lines
174
to
182
| {dhcpEnabled | ||
| ? renderChip( | ||
| t('pci_projects_project_network_private_dhcp_active'), | ||
| ODS_THEME_COLOR_INTENT.success, | ||
| ) | ||
| : renderChip( | ||
| t('pci_projects_project_network_private_dhcp_disabled'), | ||
| ODS_THEME_COLOR_INTENT.warning, | ||
| )} |
There was a problem hiding this comment.
Why create the rendChip and not use react component ?
There was a problem hiding this comment.
Not outdated, still an issue
packages/manager/apps/pci-private-network/src/data/hooks/networks/useNetworks.ts
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-private-network/src/data/hooks/networks/useNetworks.ts
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-private-network/src/pages/delete/DeleteNetwork.page.tsx
Outdated
Show resolved
Hide resolved
ref: -1826 Signed-off-by: tsiorifamonjena <[email protected]>
ref: -1826 Signed-off-by: tsiorifamonjena <[email protected]>
Comment on lines
12
to
15
| const color = { | ||
| [ResourceStatus.ACTIVE]: ODS_THEME_COLOR_INTENT.success, | ||
| [ResourceStatus.DISABLED]: ODS_THEME_COLOR_INTENT.warning, | ||
| }; |
There was a problem hiding this comment.
This could be outside of component
packages/manager/apps/pci-private-network/src/data/hooks/networks/useNetworks.ts
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-private-network/src/data/hooks/networks/useNetworks.ts
Outdated
Show resolved
Hide resolved
|
|
||
| return ( | ||
| <OsdsTabPanel | ||
| active={activeTab === PrivateNetworkTabName.LOCAL_ZONE_TAB_NAME} |
There was a problem hiding this comment.
This doesn't seem to be used ? If the component is displayed then we are on the tab
packages/manager/apps/pci-private-network/src/data/hooks/networks/useNetworks.ts
Outdated
Show resolved
Hide resolved
| name={PrivateNetworkTabName.LOCAL_ZONE_TAB_NAME} | ||
| > | ||
| <Notifications /> | ||
| {isPending ? ( |
There was a problem hiding this comment.
Maybe we should reconsider this since there is a lot of requests running in parallel we could display data network by network and display a spinner above.
This could allow to have one region down while we can still access the page
Comment on lines
-48
to
51
| path: ROUTE_PATHS.delete, | ||
| path: '', | ||
| ...lazyRouteConfig(() => | ||
| import('@/pages/delete/DeleteNetwork.page'), | ||
| import('@/pages/listing/region/PrivateNetworkRegion.page'), | ||
| ), | ||
| handle: { | ||
| tracking: 'delete', | ||
| }, | ||
| }, | ||
| ], | ||
| }, | ||
| { | ||
| path: ROUTE_PATHS.localZone, | ||
| handle: { | ||
| tracking: 'localZone', | ||
| }, | ||
| ...lazyRouteConfig(() => import('@/pages/list/List.page')), | ||
| children: [ | ||
| { | ||
| path: ROUTE_PATHS.delete, | ||
| path: ROUTE_PATHS.localZone, | ||
| ...lazyRouteConfig(() => | ||
| import('@/pages/delete/DeleteNetwork.page'), | ||
| import('@/pages/listing/localZone/PrivateNetworkLZ.page'), | ||
| ), |
There was a problem hiding this comment.
Routing seems weird, I think we should use query params instead but I don't understand how LZ is different from classic regions
ref: -1826 Signed-off-by: tsiorifamonjena <[email protected]>
ref: -1826 Signed-off-by: tsiorifamonjena <[email protected]>
Tsiorifamonjena
force-pushed
the
feat/pci-private-network_tapc-1826
branch
from
8b09ba6
to
c865939
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: TAPC-1826
feat/private-network-refactor1Description
Related