Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: problem displaying /account/ page after upgraded to redwood #96

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

hinakhadim
Copy link
Collaborator

Issue:
With Tutor v18 and Tutor Indigo v18.1.0, users are unable to view the accounts page. Tutor Indigo v18.1.0 has installation of custom indigo header and footer in learning, dashboard, profile, discussion and account MFE. All MFEs are compatible with indigo header and footer except accounts MFE. The reason is:

In redwood:
Most of the MFEs using ----> footer v14

  • footer is installed via @openedx/frontend-slot-footer package
  • footer is imported like import FooterSlot from '@openedx/frontend-slot-footer';

Account MFE -----> footer v13

  • footer is installed via @edx/frontend-component-footer
  • footer is imported like import { FooterSlot } from '@edx/frontend-component-footer';

Our indigo footer is created from footer v14 and we are installing it in all MFEs (account MFE has footer v13). More details can be found on this issue

Solves overhangio/tutor#1111

@hinakhadim hinakhadim requested a review from regisb August 16, 2024 17:45
@hinakhadim
Copy link
Collaborator Author

This PR does 2 things:

  1. Add indigo-footer to MFEs using PluginSlot. Before the footer was installed using "alias".
  2. Update the indigo-header version to ~3.0.0 from ^3.0.0

tutorindigo/plugin.py Show resolved Hide resolved
tutorindigo/plugin.py Show resolved Hide resolved
@hinakhadim
Copy link
Collaborator Author

@regisb We don't require to merge this PR. I have created a PR in tutor-mfe overhangio/tutor-mfe#221 and it has the patch for fixing this issue. The de-duplication of code will be done in the next PR (toggle button theme).

@hinakhadim hinakhadim closed this Aug 20, 2024
@hinakhadim hinakhadim reopened this Aug 26, 2024
@hinakhadim hinakhadim force-pushed the hina/account-mfe-bug branch 2 times, most recently from fc2d66b to 9f7c964 Compare August 27, 2024 07:59
@hinakhadim hinakhadim force-pushed the hina/account-mfe-bug branch from 9f7c964 to 9fe312f Compare August 27, 2024 08:02
@hinakhadim hinakhadim merged commit f9a90a4 into overhangio:master Aug 27, 2024
1 check passed
@hinakhadim hinakhadim deleted the hina/account-mfe-bug branch October 11, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

5 participants