Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up Implementation of FE JavaScript in all apps #26

Open
senakafdo opened this issue Nov 2, 2018 · 1 comment
Open

Clean-up Implementation of FE JavaScript in all apps #26

senakafdo opened this issue Nov 2, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@senakafdo
Copy link
Member

Some of the issues in the current code are as follows:

  1. Not using ES6+ syntax such as: arrow functions, string interpolation, classes/modules, class inheritance to avoid duplication of code, Set/Map datastructures.
  2. Use of default values instead of testing for undefined as in ES5.
  3. Exposing functions in the global scope.

Cleaned up code should be easy enough for someone to extend and build their own app(s). It should also be possible to build apps that combine more than one app - this can be achieved by extracting the app-specific logic into classes and having the OVE-init outside of it.

@senakafdo senakafdo added the enhancement New feature or request label Nov 2, 2018
@senakafdo senakafdo added this to the 0.2 milestone Nov 2, 2018
@senakafdo senakafdo self-assigned this Nov 2, 2018
@davidbirchwork
Copy link
Contributor

request this is conducted after #16 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants