Skip to content
This repository has been archived by the owner on May 31, 2022. It is now read-only.

Add resiliency to testimonial component #193

Closed
ann-kilzer opened this issue Jun 27, 2021 · 5 comments · Fixed by #231
Closed

Add resiliency to testimonial component #193

ann-kilzer opened this issue Jun 27, 2021 · 5 comments · Fixed by #231
Assignees
Labels
bug Something isn't working

Comments

@ann-kilzer
Copy link
Contributor

The testimonial component might show up empty if the tweet has been deleted. See here: #192

It would be great if we could detect this and be more robust.

@ann-kilzer ann-kilzer added the bug Something isn't working label Jun 27, 2021
@renderf0x
Copy link
Collaborator

I wish they'd merge this CR, as this could be easily used for this:
tonickkozlov/vue-tweet-embed#58

@renderf0x renderf0x self-assigned this Jul 1, 2021
@renderf0x
Copy link
Collaborator

Blocked on the design from @thehamspecial for the testimonials area / page, as that will define what the component should do (render a random different tweet? not render?) based on how many are in the layout, etc.

I think this will need to be a fresh component for Tweets instead of the lib we're using, but that should be easy enough given that Twitter's embed lib looks pretty straightforward.

@renderf0x
Copy link
Collaborator

Working off of @thehamspecial 's current mock of the page to add the new styling to this component too:
https://www.figma.com/proto/kdgcV9gd3cOeiSgoXY6VLM/Find-a-Doc?node-id=4%3A16&scaling=fit-width&page-id=0%3A1&hotspot-hints=0&hide-ui=1

@thehamspecial - do you have a mock for what you'd want this Twitter component to look like on a small screen size?

@thehamspecial
Copy link

@renderf0x Yup, here's the layout on small screens.

Here's the desktop view. Let me know if you have feedback!

@renderf0x
Copy link
Collaborator

Looks great @thehamspecial - will work on getting the Twitter portion up and running.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants