Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify and refactor state management #163

Closed
olabini opened this issue Oct 2, 2018 · 5 comments
Closed

Simplify and refactor state management #163

olabini opened this issue Oct 2, 2018 · 5 comments
Assignees
@olabini @giovaneliberato
Labels
architecture importance high An issue that is absolutely necessary to have done before final release

Comments

@olabini
Copy link
Contributor

olabini commented Oct 2, 2018

This issue is about track everything related to the client orchestration, making sure state is read and available at the right times, and that publication happens when it should.
@olabini
Copy link
Contributor Author

olabini commented Oct 2, 2018

There are several issues that are closely connected to this one:

@claucece claucece added importance high An issue that is absolutely necessary to have done before final release architecture labels Oct 2, 2018
@olabini olabini self-assigned this Oct 2, 2018
@claucece claucece added this to the October milestone Oct 2, 2018
@olabini
Copy link
Contributor Author

olabini commented Oct 2, 2018 •
edited
Loading

This involves these objects:

  • Private long term key
  • Forging key
  • Client profile
  • Expired client profile (only loading etc)
  • Prekey profile
  • Expired prekey profile (only loading etc)
  • Prekey messages
  • Private material corresponding to prekey profile
  • Private material corresponding to prekey messages
  • Fingerprints (for now, let's keep them outside of orchestration - the life cycle is different)
  • Instance tags (for now, let's keep them outside of orchestration - the life cycle is different)

olabini added a commit that referenced this issue Oct 2, 2018
@olabini
Part of #163 - work on orchestration of client profile a bit, also ad…
fe32024 
…d the verify_ family of functions. Centralize creation of client profiles to ONLY happen through the orchestration
olabini added a commit that referenced this issue Oct 3, 2018
@olabini
manage client and prekey profile publishing correctly, from the orche…
82d0adf 
…stration side only. Also fix some potential problems with reading client profiles and prekey profiles. Also add metadata serialization and deserialization for these types - part of #163
olabini added a commit that referenced this issue Oct 4, 2018
@olabini
Part of #163 - remove separate management of the shared prekey, inste…
fed5ec7 
…ad make it part of the prekey profile structure
olabini added a commit that referenced this issue Oct 4, 2018
@olabini
[#163] - The shared prekey pair is optional
7e439d0
@olabini
Copy link
Contributor Author

olabini commented Oct 4, 2018

With the latest commits the private prekey profile material is now managed together with the prekey profile, so no need to manage it separately.

olabini added a commit that referenced this issue Oct 4, 2018
@olabini
Further work on prekey messages, for #163
f06a3b9
olabini added a commit that referenced this issue Oct 4, 2018
@olabini
[#163] sort out prekey messages and private material for them
81245fc
olabini added a commit to otrv4/pidgin-otrng that referenced this issue Oct 4, 2018
@olabini
Part of otrv4/libotr-ng#163 - sort out prekey messages
9d39c52
olabini added a commit that referenced this issue Oct 5, 2018
@olabini
[#163] - Add final fixes on long term keys orchestration, and some ot…
465aaad 
…her smaller fixes
olabini added a commit to otrv4/pidgin-otrng that referenced this issue Oct 5, 2018
@olabini
[otrv4/libotr-ng#163] - Finishing up long term key management, and fi…
442ed29 
…x a bug in prekey messages storage
olabini added a commit that referenced this issue Oct 5, 2018
@olabini
[#163] - Add management of the forging key to the orchestration, and …
9de79a0 
…remove it from other places
olabini added a commit to otrv4/pidgin-otrng that referenced this issue Oct 5, 2018
@olabini
[otrv4/libotr-ng#163] - Add suppotr for proper management of the forg…
6b12c87 
…ing key
olabini added a commit that referenced this issue Oct 5, 2018
@olabini
[#163] - Manage expired client profiles
01925d5
olabini added a commit to otrv4/pidgin-otrng that referenced this issue Oct 5, 2018
@olabini
[otrv4/libotr-ng#163] - Add support for expired prekey profiles
c52d5bb
olabini added a commit that referenced this issue Oct 6, 2018
@olabini
[#163] - We should create a new client profile when we are close to e…
ef718ef 
…xpiry
olabini added a commit that referenced this issue Oct 6, 2018
@olabini
[#163] - Sort out expired prekey profiles
2b4c13e
olabini added a commit that referenced this issue Oct 6, 2018
@olabini
[#163] - Finish up work on expired prekey profile
6f0eb24
olabini added a commit to otrv4/pidgin-otrng that referenced this issue Oct 6, 2018
@olabini
[otrv4/libotr-ng#163] - Finish up work on expired prekey profile
86cbbd4
@olabini
Copy link
Contributor Author

olabini commented Oct 6, 2018

I would say this is done. At some point I'll tackle the v3 keys, instance tags and fingerprints, but I think I'll do that outside of this issue.

@olabini olabini closed this as completed Oct 6, 2018
@claucece
Copy link
Member

claucece commented Oct 7, 2018

Thanks @olabini

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olabini olabini

@giovaneliberato giovaneliberato

Labels
architecture importance high An issue that is absolutely necessary to have done before final release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@olabini @giovaneliberato @claucece