Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net.connect issue with Node.js 7.10.0 #117

Open
watson opened this issue May 5, 2017 · 3 comments
Open

net.connect issue with Node.js 7.10.0 #117

watson opened this issue May 5, 2017 · 3 comments

Comments

@watson
Copy link

watson commented May 5, 2017

A commit recently landed in Node core that was released as v7.10.0 two days ago.

It breaks async-listener and therefore also continuation-local-storage because net.connect no longer calls Socket.prototype.connect. Furthermore, it's not possible to simply monkey-patch net.connect in async-listener because it's being called internally in node by simply referencing the connect function and not the exports.connect function.

I'm working on fixing this together with @cjihrig and @jasnell. See nodejs/node#12852 for details.

It will most likely be released as v7.10.1.

Here's the relevant issue in async-listener: othiym23/async-listener#109

@watson
Copy link
Author

watson commented May 8, 2017

The work to fix this have now been moved to nodejs/node#12861

@othiym23
Copy link
Owner

This seems to still be busted as of Node 9 -- is there something we need to do to address this in either async-listener or CLS?

@sabakugaara
Copy link

test/net-events.tap.js failed, in node8+

  • platform: mac 10.12.6
  • node version: 8.9.0

this may work: othiym23/async-listener#129, @watson @othiym23, I need some help, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants