Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

join*() functions to compliment the split*() ones #36

Open
bradleythughes opened this issue Aug 30, 2017 · 3 comments
Open

join*() functions to compliment the split*() ones #36

bradleythughes opened this issue Aug 30, 2017 · 3 comments

Comments

@bradleythughes
Copy link

While doing SDP munging, it's handy to use SDPUtils to split things up and find the pieces you want to modify before putting it all back together again, so I wondered if there should be some helpers for doing so (putting an SDP back together).

@fippo
Copy link
Member

fippo commented Aug 30, 2017

the main use case I am interested in here is this one:

return SDPUtils.joinSections(SDPUtils.splitSections(sdp).map(section => ...))

@fippo
Copy link
Member

fippo commented Mar 18, 2018

do we need joinSections and joinLines? Or just join()?

@bradleythughes
Copy link
Author

For API symmetry, joinSections() and joinLines() maybe makes sense... but if the implementation is the same for both... I dunno :|

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants