Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Twitter Hook #84

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added Twitter Hook #84

wants to merge 2 commits into from

Conversation

Muljayan
Copy link
Contributor

closes #14

Included a twitter hook

image

No tweets are present in the fixmeparser twitterpage

@himankpathak
Copy link
Contributor

the widget box currently looks too big how about setting a max-height for the widget. I think showing about 2 tweets at a time would be just fine. @Muljayan

@alexdor
Copy link
Member

alexdor commented Oct 22, 2018

@Muljayan nice work : ) could you display only one tweet and try to keep it as close as possible to this deigns https://github.com/ossn/fixme/blob/master/screens/desktop/Mozilla_Fixme_Screen01_Homepage_A.png ?

@Muljayan
Copy link
Contributor Author

@himankpathak thanks for the suggestion :)
@alexdor i noticed that the twitter api has a limit to get tweets, on the free tier that is. How about putting a get request to the twitter api on our backend every few minutes or so to fetch the latest tweets and then make the front request from our back end.

@alexdor
Copy link
Member

alexdor commented Oct 24, 2018

@Muljayan that's a good idea, what's the limit for the twitter api?

@Muljayan
Copy link
Contributor Author

image
image

It says 900-1500 requests per window. Where one window is 15mins . So i think if we don't have 900-1500 people using the app in a span of 15 mins at once we should be fine.
We might also have to consider those working on PRs to further enhance this app. When ever they start the server, refresh the page etc. It'll be taken as a hit right

@siddhant1
Copy link
Collaborator

Is anyone working on this right now?

@alexdor
Copy link
Member

alexdor commented Feb 28, 2019

As far as I know, no it would be nice to have an implementation which is closer to the designs https://github.com/ossn/fixme/blob/master/screens/desktop/Mozilla_Fixme_Screen01_Homepage_A.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build a twitter hook
4 participants