Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are no tests #126

Open
alexdor opened this issue Mar 2, 2019 · 14 comments
Open

There are no tests #126

alexdor opened this issue Mar 2, 2019 · 14 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@alexdor
Copy link
Member

alexdor commented Mar 2, 2019

Currently there are no tests in this repo. It would be nice if we could write some tests.

@alexdor alexdor added enhancement New feature or request help wanted Extra attention is needed labels Mar 2, 2019
@nik72619c
Copy link
Member

nik72619c commented Mar 2, 2019

tests like CicleCI?

@alexdor
Copy link
Member Author

alexdor commented Mar 3, 2019

Before we add a CI, we first have to write them in Jest. Afterwards we could add a CI so it could run the tests automatically : )

@nik72619c
Copy link
Member

Could you provide some scenarios...what are the tests gonna be regarding?

@nik72619c nik72619c added the additional info requested This issue is awaiting for additional information from it's author label Mar 3, 2019
@alexdor
Copy link
Member Author

alexdor commented Mar 3, 2019

It would be nice to test the following:

  • Test that all pages render without crashing
  • Test that Learn More button works
  • Test that Issue, Projects, About links work
  • Test that 18 Projects navigates to projects page when clicked
  • Test the search form in the homepage
  • Test that the form in the issues page works and that it updates the url
  • Test that the form in the issues page parses properly the url params (for example when navigating to this https://fixme.ossn.club/issues?experience_needed=moderate&language=javascript&type=bugfix&project_id=c03fc409-d943-4b18-9fa3-78c46a1f06cc&ordering= the website should parse the language, the project_id and the type and it should enable the checkboxes on the filter form)
  • Test that each issue card is a link (at the issues page)
  • Test that each project card (at the projects page)

Of course not all of the tests have to be done at once but we can start with a few and then add more on top of them.

@alexdor alexdor removed the additional info requested This issue is awaiting for additional information from it's author label Mar 3, 2019
@nik72619c
Copy link
Member

nik72619c commented Mar 3, 2019

Sounds good...gonna work on this

@alexdor
Copy link
Member Author

alexdor commented Mar 3, 2019

Sounds good, let me know if you face any issues : )

@aswinmprabhu
Copy link

This seems like a big task. @nik72619c Maybe we can share this task.

@alexdor
Copy link
Member Author

alexdor commented Mar 11, 2019

@aswinmprabhu sounds like a good idea, I don't know the status of @nik72619c's work but splitting it up would unburden him a lot I think

@nik72619c
Copy link
Member

no issues !

@alexdor
Copy link
Member Author

alexdor commented Mar 11, 2019

@nik72619c could you upload a version with the basic structure that you are working on in the repo so that both of you work on the same structure?

@nik72619c
Copy link
Member

the structure that I am working on consists of a test folder inside components folder, so is it okay @alexdor ?

@alexdor
Copy link
Member Author

alexdor commented Mar 11, 2019

Usually you add general tests inside the src folder and component specific tests inside each component folder. But your solution could work as well : )

Could you split up the tests between you two so you don't have any overlap on your work?

@nik72619c
Copy link
Member

yea sure
I will just finish up with my checklist of tests and rest can be taken up by @aswinmprabhu

@aswinmprabhu
Copy link

Hey @nik72619c, can you push your scaffold soon so that I can start working? Also what library are you using?
react-testing-library + Jest seems like a great fit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants