-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There are no tests #126
Comments
tests like CicleCI? |
Before we add a CI, we first have to write them in Jest. Afterwards we could add a CI so it could run the tests automatically : ) |
Could you provide some scenarios...what are the tests gonna be regarding? |
It would be nice to test the following:
Of course not all of the tests have to be done at once but we can start with a few and then add more on top of them. |
Sounds good...gonna work on this |
Sounds good, let me know if you face any issues : ) |
This seems like a big task. @nik72619c Maybe we can share this task. |
@aswinmprabhu sounds like a good idea, I don't know the status of @nik72619c's work but splitting it up would unburden him a lot I think |
no issues ! |
@nik72619c could you upload a version with the basic structure that you are working on in the repo so that both of you work on the same structure? |
the structure that I am working on consists of a test folder inside components folder, so is it okay @alexdor ? |
Usually you add general tests inside the src folder and component specific tests inside each component folder. But your solution could work as well : ) Could you split up the tests between you two so you don't have any overlap on your work? |
yea sure |
Hey @nik72619c, can you push your scaffold soon so that I can start working? Also what library are you using? |
Currently there are no tests in this repo. It would be nice if we could write some tests.
The text was updated successfully, but these errors were encountered: