Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[simple-social-icons] shortcode #50

Open
nickcernis opened this issue Jan 24, 2017 · 6 comments
Open

[simple-social-icons] shortcode #50

nickcernis opened this issue Jan 24, 2017 · 6 comments
Assignees
Milestone

Comments

@nickcernis
Copy link
Contributor

We've seen repeated requests in the WP.org forums for a Simple Social Icons shortcode to output icons within a post.

https://wordpress.org/support/topic/shortcode-477/

May require the addition of a global settings page like we have in Simple Share.

@marksabbath
Copy link
Contributor

Hey @nickcernis since this is a widget, what do you think about using an approach like amr-shortcode-any-widgetplugin? Is there any suggestion in your mind related to this?

@nickcernis
Copy link
Contributor Author

nickcernis commented Aug 30, 2018

@marksabbath How do you feel about putting this issue into backlog for now?

It looks like a dedicated shortcode would be a bigger project (requires plugin restructuring and a custom admin page). I'm not sure the utility a shortcode offers is worth it right now in light of Gutenberg. A Gutenberg block may be more useful once that becomes available as an option to us.

If the amr-shortcode-any-widget plugin works as an alternative, we could suggest that as a workaround for now for those asking.

cc @mattlawck @dreamwhisper

@marksabbath
Copy link
Contributor

Sounds like a reliable plan @nickcernis and I do agree that maybe, a Gutenberg block would be way more useful than a shortcode at this point.

Let's wait for @dreamwhisper and @mattlawck thoughts :)

Thanks for your help man!

@mattlawck
Copy link

I agree with that, if its a large feature that doesn't yet exist, should probably be the focus of its own version?

@marksabbath marksabbath modified the milestones: 2.1, Backlog Aug 30, 2018
@marksabbath
Copy link
Contributor

Yeap, maybe a version focused on this feature would make more sense. Moving it to backlog. Thanks guys!

@cinghaman
Copy link

Since Gutenberg block has been there for a while, any chance for adding social icons to Gutenberg block?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants