Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get social count from short URL and regular permalink #27

Open
NicktheGeek opened this issue Aug 27, 2014 · 14 comments
Open

get social count from short URL and regular permalink #27

NicktheGeek opened this issue Aug 27, 2014 · 14 comments

Comments

@NicktheGeek
Copy link
Contributor

We've had a request to switch the social count to check the short URL. We cannot reasonably switch to using the short URL only but we can use it as an alternate URL.

Basically, this will use the regular URL for sharing and adds a check against an alternate URL that is the short (ugly) URL for the post. It concatenates the count for both values to show. This way, if someone had been sharing the short URL for their post and switches to simple share, it will keep the count for those short URL shares as social proof.

An alternate method here, which I can easily switch to, is to make the short URL the main URL so it is shared. This frees up potential characters for Twitter shares so it might be preferable, though twitter is doing some stuff with shortening automatically now so the gain is less than it might have been in the past. In this case the "alternate" URL would be the pretty permalink.

@bgardner @omiq what are your thoughts?

@bgardner
Copy link
Contributor

Was the request an isolated one? Is this a flip in methodology based on one person, or an ongoing trend?

If it's working as is, I'd suggest just making the shortlink be the backup, rather than the primary. JMO.

@NicktheGeek
Copy link
Contributor Author

this was a request that came via a specific VIP customer. In my testing I think it will probably be safer to do as a backup since if the initial address fails that causes some issues with the output. I can find and fix that if we make the short link the primary, but I'm not seeing a huge benefit to doing so.

NicktheGeek added a commit that referenced this issue Aug 29, 2014
@NicktheGeek
Copy link
Contributor Author

for testing verify the counts work correctly and test with post/page short URL to verify the count is updated.

@katyfb13
Copy link

katyfb13 commented Sep 9, 2014

@NicktheGeek I'm afraid I don't know how to test this. When I click the social icons on the front end, I don't see an option to use shortened urls. Is that what I am looking for or otherwise, please provide more details as to how to test this.

@katyfb13 katyfb13 added this to the Rainmaker 2.0 milestone Sep 10, 2014
@NicktheGeek
Copy link
Contributor Author

@katyfb13 sorry missed your comment. You will need to share the URL using the "pretty" permalink and the short "ugly" URL. This looks like
example.com/post-title
example.com/?p=123

It should count both in the returned value.

@katyfb13
Copy link

@NicktheGeek where do I get the pretty permalink? I don't see that option on the front end when I go to share it using the icons. Or is this supposed to be tested another way?

@NicktheGeek
Copy link
Contributor Author

The pretty permalink is the default URL for your page. The short "ugly" permalink can be accessed via a button in the editor.
screen shot 2014-09-10 at 2 39 31 pm

@katyfb13
Copy link

okay, just to confirm this is the process to test:

  1. click a share button
  2. in the share window, make sure the url is of the format /post-title > share that
  3. click the share button again
  4. replace the link with the ugly permalink pulled from the post admin editor
  5. check share counts to make sure both shares are recorded

@NicktheGeek
Copy link
Contributor Author

that should do the trick, though technically you don't have to use the share button to share on the service.

@katyfb13
Copy link

I don't think this is working properly. I shared the default url that the app uses (the /post-title) and it was recorded. Then I shared it again on twitter using the "get shortlink" button in the admin (this was an ugly one though) and that share was not recorded. I tried this twice and neither one was recorded.

Let me know if I am not testing it properly.

@omiq
Copy link

omiq commented Sep 10, 2014

@NicktheGeek any ideas? So long as the full long URL works we can live with it but as we are waiting on another issue that is holding up packaging, do you think you could take a look?

@katyfb13 katyfb13 modified the milestones: Rainmaker 2.0, Rainmaker 2.1 Sep 11, 2014
@katyfb13
Copy link

looks like this is not going to make it into 2.0 so I have moved it to the next RM sprint

@NicktheGeek
Copy link
Contributor Author

sorry, looked through the code here and I realized that I was having some problems in testing and disabled the code in the production (.min) file. It's still got some work that needs doing.

@omiq
Copy link

omiq commented Sep 11, 2014

We can do a post 2.0 patch, no problem

@katyfb13 katyfb13 modified the milestones: Rainmaker 2.2, Rainmaker 2.1 Nov 5, 2014
@NicktheGeek NicktheGeek modified the milestone: Rainmaker 2.2 Jan 16, 2015
@katyfb13 katyfb13 added this to the Rainmaker Backlog milestone Feb 4, 2015
@katyfb13 katyfb13 added this to the Rainmaker Backlog milestone Feb 4, 2015
@NicktheGeek NicktheGeek removed this from the Rainmaker Backlog milestone Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants