Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color Selection for Sharing Icons #17

Open
katyfb13 opened this issue Feb 18, 2014 · 17 comments
Open

Color Selection for Sharing Icons #17

katyfb13 opened this issue Feb 18, 2014 · 17 comments

Comments

@katyfb13
Copy link

Social Sharing > Allowing selection of a color for all icons would be a great enhancement so users could show a single color without needing custom CSS. ( Like http://www.briangardner.com/downton-abbey/ )

@bgardner
Copy link
Contributor

+1 on this. Just adding an option to override social media brand colors with a color dropper hexcode one.

@NicktheGeek
Copy link
Contributor

Just to be clear, this would be a single color that would override all of the colors at once, not something we would make available to change each social button to suit a given color scheme right?

@bgardner
Copy link
Contributor

Right, like my site, I have all icons set to use background color #000 on icons across the board. This is just for personal brand. So options would either be a) use social colors out of the box b) new option to set one color for all icons or c) customize your own styles ala style.css.

@bgardner
Copy link
Contributor

bgardner commented Jul 9, 2014

Just wanted to ping you @NicktheGeek on this again, as I can see this easily being the most requested item. Yes, we can tell people how to do this via CSS, but for Rainmaker folks, a simple color picker override would be a brilliant addition to the plugin.

@NicktheGeek
Copy link
Contributor

I'm a bit torn on this. I'd like to see if maybe Norcross would be interested in adding an option to DPP if Genesis Simple Share is active. For RM I feel like that would be better than having design options in more than one place. Otherwise maybe I could hook into DPP so the options would be there.

@omiq
Copy link

omiq commented Jul 9, 2014

Agreed, or provide hooks so we can add it. I'd like to centralise as much as we can versus having similar features spread out.

@omiq
Copy link

omiq commented Nov 19, 2014

Right now DPP is off the table so what is the best non-DPP solution?

@bgardner
Copy link
Contributor

I honestly think a checkbox for "universal color" and a color picker right where the Share options are is the best user experience. JMO.

@dreamwhisper
Copy link
Contributor

I honestly think a checkbox for "universal color" and a color picker right where the Share options are is the best user experience

I'm ok with this approach since it centralizes all the settings for social sharing.

Along with this, we need a filter that can be used for default values set in the theme.

@NicktheGeek
Copy link
Contributor

Right now DPP is off the table so what is the best non-DPP solution?

I'd like to use the Customizer if we are going to add any color options just for this plugin. We are moving other color settings to the customizer for some of the newer themes so it makes more sense to me to have colors and styles handled in a central place.

@bgardner
Copy link
Contributor

I'm in support of any method that allows us to universally change icon colors to one color. :-)

@dreamwhisper
Copy link
Contributor

I'd like to use the Customizer if we are going to add any color options just for this plugin.

That works for me too :)

@katyfb13
Copy link
Author

Yall want to get this in to Rainmaker 2.2? And who is the lucky dev?

@NicktheGeek
Copy link
Contributor

@katyfb13 I think we can shoot for 2.2 and I can dev this since it's in GSS. Do you want to make a tracking issue in the RM repo though?

@katyfb13 katyfb13 added this to the Rainmaker 2.2 milestone Nov 19, 2014
@katyfb13
Copy link
Author

Do you want to make a tracking issue in the RM repo though?

yes will do! Thanks.

@katyfb13
Copy link
Author

actually, it's already there
https://github.com/copyblogger/synthesis-platform/issues/1142

@NicktheGeek NicktheGeek modified the milestone: Rainmaker 2.2 Jan 16, 2015
@katyfb13 katyfb13 modified the milestone: Rainmaker Backlog Feb 4, 2015
@dreamwhisper
Copy link
Contributor

we need a filter that can be used for default values set in the theme

Also, border radius would be helpful.

@NicktheGeek NicktheGeek removed this from the Rainmaker Backlog milestone Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants