Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the tests separately #14

Open
thofma opened this issue May 21, 2021 · 2 comments
Open

Run the tests separately #14

thofma opened this issue May 21, 2021 · 2 comments

Comments

@thofma
Copy link
Contributor

thofma commented May 21, 2021

In AA, we test four packages (https://github.com/Nemocas/AbstractAlgebra.jl/blob/master/OscarCI.toml). Would it be possible to have the four tests in separate jobs? The problem we have at the moment is that the Oscar tests run first, but they might (and often do) fail for unrelated reasons. Then all the tests of the other packages are not run.

I am not sure we want to have separate jobs or handle it inside the julia command here: https://github.com/oscar-system/OscarDevTools.jl/blob/master/src/OscarCI.jl#L283

Thoughts?

Edit: Sorry, I just checked. The Oscar tests run last. But my problem is that I have to scroll through everything to spot which tests passed, which did not, and to find out which did not even run. I hope you get my point.

@benlorenz
Copy link
Member

Not totally sure how to handle this:

  • Expanding this into separate jobs (via an additional axis) will increase the already rather large job-list even further and make it difficult to find the correct build. (also this will probably get rather complicated in the combination with the includes ...)
  • Unfortunately I don't think there is a way to dynamically create additional steps (e.g. per package). But we could pre-define steps for all package-tests that might run (e.g. all main oscar packages) and just skip those that are not requested in the current job. (And at the end run any remaining package-tests in one extra step)
  • Maybe we can try running the tests with TestReports.jl and use something like https://github.com/marketplace/actions/junit-report-action or https://github.com/marketplace/actions/publish-unit-test-results to summarize the results.

@thofma
Copy link
Contributor Author

thofma commented May 25, 2021

Thanks for your feedback. I agree that doing it on the level of jobs is not the best idea. I will probably play around with TestReports.jl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants