Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Oscar 1.2.1 #4291

Closed
fingolfin opened this issue Nov 7, 2024 · 4 comments
Closed

Release Oscar 1.2.1 #4291

fingolfin opened this issue Nov 7, 2024 · 4 comments

Comments

@fingolfin
Copy link
Member

fingolfin commented Nov 7, 2024

@thofma point out that we fixed at least one regression since 1.2.0 which should be quickly released. Fine by me. I think the process will be to cherry-pick it and possible more onto the release-1.2 branch in close coordination with @benlorenz. I suggested we create a list of PRs here that we'd like to see backported. Please feel free to add issues to this list, or to propose them in the comments.

We can then decide e.g. next Wednesday if the list is complete and we want to release.

@fingolfin
Copy link
Member Author

I see several PRs were added by @lgoettgens . I assume triage agreed on those.

But was there also a discussion how and when and who will do this? Perhaps "someone" should open a PR for the release-1.2 branch with backports of these PR?

@lgoettgens
Copy link
Member

I see several PRs were added by @lgoettgens . I assume triage agreed on those.

No. At triage we only reminded everyone that we are planning a 1.2.1 release. The changes above were just by me looking through the recently merged PRs what I thought would be fine to backport.
Either triage next week or @benlorenz / @aaruni96 would need to decide that these are indeed the ones we want to backport.

But was there also a discussion how and when and who will do this? Perhaps "someone" should open a PR for the release-1.2 branch with backports of these PR?

@benlorenz wanted to take care of this iirc

@lgoettgens
Copy link
Member

I think it would be great if we could include #4321 and 9140f6d (#4325) as well.

@benlorenz
Copy link
Member

I think it would be great if we could include #4321 and 9140f6d (#4325) as well.

Done (for the first one only one of the two markers was missing on the release branch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants