From e1961584b6cc75c2d92ba37f5160cf619cefe40e Mon Sep 17 00:00:00 2001 From: Keno Fischer Date: Wed, 20 Nov 2024 03:25:37 +0000 Subject: [PATCH 1/3] Add an `invokelatest` that may be required in 1.12 This test currently relies on implicit world age increments at top level. We're re-evaluating where these go because julia is currently inconsistent about it in the interpreter, compiler and inference. To make sure this test keeps working on 1.12, add an explicit world age increment. See https://github.com/JuliaLang/julia/pull/56509. --- test/runtests.jl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/runtests.jl b/test/runtests.jl index ef862c4..b822136 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -154,6 +154,8 @@ end # skip tables containing only unipotent character types startswith(table, "uni") && continue - @test order(g) == sum(number_of_characters(c) * degree(c)^2 for c in g) + invokelatest() do + @test order(g) == sum(number_of_characters(c) * degree(c)^2 for c in g) + end end end From df973c0171c6d782490b6bb0966561977cd49ab9 Mon Sep 17 00:00:00 2001 From: Max Horn Date: Wed, 27 Nov 2024 14:11:42 +0100 Subject: [PATCH 2/3] Update test/runtests.jl --- test/runtests.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/runtests.jl b/test/runtests.jl index b822136..49be934 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -154,7 +154,7 @@ end # skip tables containing only unipotent character types startswith(table, "uni") && continue - invokelatest() do + Base.invokelatest() do @test order(g) == sum(number_of_characters(c) * degree(c)^2 for c in g) end end From ff0443dd239fe8fd148a778bacce6bd04f87713d Mon Sep 17 00:00:00 2001 From: Max Horn Date: Wed, 27 Nov 2024 14:12:49 +0100 Subject: [PATCH 3/3] Update test/runtests.jl --- test/runtests.jl | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/runtests.jl b/test/runtests.jl index 49be934..a8927a8 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -154,6 +154,8 @@ end # skip tables containing only unipotent character types startswith(table, "uni") && continue + # Workaround that may be needed in Julia >= 1.12. Can be removed + # when we manage to remove the need for `eval` when loading tables. Base.invokelatest() do @test order(g) == sum(number_of_characters(c) * degree(c)^2 for c in g) end