Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rear restore in ha #20564

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Rear restore in ha #20564

merged 1 commit into from
Nov 6, 2024

Conversation

hadeskun
Copy link
Contributor

@hadeskun hadeskun commented Nov 6, 2024

lpalovsky
lpalovsky reviewed Nov 6, 2024
View reviewed changes
tests/ha/rear_restore.pm Outdated Show resolved Hide resolved
BillAnastasiadis
BillAnastasiadis approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@BillAnastasiadis BillAnastasiadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - please squash commits before or on merge

alvarocarvajald
alvarocarvajald reviewed Nov 6, 2024
View reviewed changes
Copy link
Contributor

@alvarocarvajald alvarocarvajald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you squash the commits into one? At least this time you appear as the author :)

tests/ha/rear_restore.pm Outdated Show resolved Hide resolved
@hadeskun
Fixing rear restore test for ha
89b58e8 
Fixing rear restore test for ha.
mpagot
mpagot approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@mpagot mpagot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alvarocarvajald
alvarocarvajald approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@alvarocarvajald alvarocarvajald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvarocarvajald
Copy link
Contributor

alvarocarvajald commented Nov 6, 2024 •
edited
Loading

Ran the VRs again:

@alvarocarvajald
Copy link
Contributor

All VRs are green across 2 builds and both architectures. Merging this.

@alvarocarvajald alvarocarvajald merged commit c524c3f into os-autoinst:master Nov 6, 2024
10 checks passed
@lpalovsky
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpalovsky lpalovsky lpalovsky left review comments

@mpagot mpagot mpagot approved these changes

@BillAnastasiadis BillAnastasiadis BillAnastasiadis approved these changes

@alvarocarvajald alvarocarvajald alvarocarvajald approved these changes

@a-kpappas a-kpappas Awaiting requested review from a-kpappas a-kpappas is a code owner

@Amrysliu Amrysliu Awaiting requested review from Amrysliu Amrysliu is a code owner

@emiura emiura Awaiting requested review from emiura emiura is a code owner

@jankohoutek jankohoutek Awaiting requested review from jankohoutek jankohoutek is a code owner

@lilyeyes lilyeyes Awaiting requested review from lilyeyes lilyeyes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hadeskun @alvarocarvajald @lpalovsky @BillAnastasiadis @mpagot