aistack_basic test #20427
Open
aistack_basic test #20427
+844
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarunachalam
requested review from
mloviska,
jlausuch,
ricardobranco777,
pdostal,
grisu48,
asmorodskyi and
m-dati
as code owners
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
yarunachalam
force-pushed
the
aistack_basic
branch
8 times, most recently
from
3b1407a
to
f45aa4f
Compare
m-dati
reviewed
Oct 18, 2024
m-dati
reviewed
Oct 18, 2024
m-dati
reviewed
Oct 18, 2024
m-dati
reviewed
Oct 18, 2024
yarunachalam
force-pushed
the
aistack_basic
branch
9 times, most recently
from
7ff4edd
to
0a292a9
Compare
yarunachalam
force-pushed
the
aistack_basic
branch
4 times, most recently
from
0955912
to
e5ff26a
Compare
m-dati
reviewed
Nov 19, 2024
m-dati
reviewed
Nov 19, 2024
m-dati
reviewed
Nov 19, 2024
m-dati
reviewed
Nov 19, 2024
yarunachalam
force-pushed
the
aistack_basic
branch
from
e5ff26a
to
54e3895
Compare
yarunachalam
force-pushed
the
aistack_basic
branch
3 times, most recently
from
fb3a4eb
to
9a149ac
Compare
m-dati
reviewed
Nov 20, 2024
|
LGTM, after clarified $docker_user_name var. assignment in L#96. |
m-dati
previously approved these changes
Nov 20, 2024
yarunachalam
force-pushed
the
aistack_basic
branch
7 times, most recently
from
040f0f9
to
13c98d8
Compare
foursixnine
requested changes
Nov 21, 2024
There was a problem hiding this comment.
I might have some other nipticks and that's not reason to keep dragging this on my end, aside aside from the data-url thing, looks good.
After adjusting the code, feel free to dismiss my review or request re-review
wrt nvidia
I cannot reuse this code. ` trup_call("pkg install -y --auto-agree-with-licenses nvidia-open-driver-G06-signed-kmp=$driver_version nvidia-compute-utils-G06=$driver_version");
`
| my $git_token = get_var('_SECRET_SSH'); | ||
| my $ing_ver = get_var('ING_VERSION'); | ||
| my $local_storage_name = 'local_path_storage.yaml'; | ||
| my $local_path_url = 'https://raw.githubusercontent.com/os-autoinst/os-autoinst-distri-opensuse/54e38954acd015490d85e7614c00c54db46ed9f7/data/aistack/local_path_storage.yaml'; |
There was a problem hiding this comment.
Suggested change
| my $local_path_url = 'https://raw.githubusercontent.com/os-autoinst/os-autoinst-distri-opensuse/54e38954acd015490d85e7614c00c54db46ed9f7/data/aistack/local_path_storage.yaml'; | |
| my $local_path_url = data_url('local_path_storage.yaml'); |
?
Comment on lines
+118
to
+120
| # local-path-storage.yaml is a copy off https://raw.githubusercontent.com/rancher/local-path-provisioner/v0.0.28/deploy/local-path-storage.yaml | ||
| #assert_script_run( "curl " . data_url("aistack/$local_storage_name") . " -o $local_storage_name", 60); | ||
| assert_script_run("kubectl apply -f $local_path_url", timeout => 120); |
There was a problem hiding this comment.
I guess is connected to the above?
yarunachalam
force-pushed
the
aistack_basic
branch
2 times, most recently
from
696b32b
to
a27d6e5
Compare
yarunachalam
force-pushed
the
aistack_basic
branch
from
a27d6e5
to
6579606
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both flavor test passed
PR: create test env for AI private-ai-stack test env for 2 flavor sle-micro-6 test env and sle-micro-6 with nvidia driver and gpu enabled