-
-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a delegate
authenticator
#1152
Labels
feat
New feature or request.
Comments
yunier-rojas
added a commit
to yunier-rojas/oathkeeper
that referenced
this issue
Mar 2, 2024
## Problem Summary This merge request addresses issue !669 surrounding the behavior of the "noop" authentication method, which underwent changes in commit 6f8ab4f. Reverting these changes to restore the previous behavior is challenging due to the potential for breaking existing systems. To mitigate this risk, we propose implementing a new authenticator named "delegate" to replicate the original behavior of the "noop" method. ## Ideal Solution To address this issue, our proposed solution is to implement a new authenticator named "delegate" that replicates the original behavior of the "noop" method. This approach ensures that existing systems in production remain stable and unaffected by changes, while also providing users who prefer the old behavior with an option to utilize it. By introducing the "delegate" authenticator, we mitigate the risk of breaking changes while offering flexibility to users who require the previous behavior. ## Changes Proposed 1. **New Authenticator Module**: This MR adds a new authenticator module named "delegate" to replicate the original behavior of the "noop" method. 3. **Integration Tests**: Integration tests will be added to validate the functionality of the "delegate" authenticator, ensuring compatibility and reliability. 4. **Documentation Updates**: Documentation will be updated to include details about the new "delegate" authenticator, its configuration options, and usage examples. ## Related Issues ory#1152 ory#669 closes 1152
This was referenced Mar 2, 2024
yunier-rojas
added a commit
to yunier-rojas/ory-docs
that referenced
this issue
Mar 7, 2024
ory/oathkeeper#1153 implements a new authenticator to allow authn/authz delegation to upstream services. Relates to ory/oathkeeper#1152
yunier-rojas
added a commit
to yunier-rojas/ory-docs
that referenced
this issue
Mar 7, 2024
ory/oathkeeper#1153 implements a new authenticator to allow authn/authz delegation to upstream services. Relates to ory/oathkeeper#1152
yunier-rojas
added a commit
to yunier-rojas/ory-docs
that referenced
this issue
Mar 7, 2024
ory/oathkeeper#1153 implements a new authenticator to allow authn/authz delegation to upstream services. Relates to ory/oathkeeper#1152
yunier-rojas
added a commit
to yunier-rojas/ory-docs
that referenced
this issue
Mar 7, 2024
ory/oathkeeper#1153 implements a new authenticator to allow authn/authz delegation to upstream services. Relates to ory/oathkeeper#1152
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Preflight checklist
Ory Network Project
No response
Describe your problem
A long debate has been around the behaviour of
noop
authentication since some changes were introduced in commit 6f8ab4f7d. Changing the behaviour of such an authenticator now to the previous one must be considered breaking change and therefore, hard to do.Describe your ideal solution
A possible solution could be to implement a new authenticator called
delegate
that implements the old behaviour ofnoop
. This way, we ensure systems in production don't start breaking and users interested in having the old behaviour can still use it.Workarounds or alternatives
Non that I'm aware of 😞
Version
v0.40.6
Additional Context
No response
The text was updated successfully, but these errors were encountered: