Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sexagesimal positions #175

Closed
mwapst opened this issue Jun 27, 2024 · 2 comments · Fixed by #262
Closed

Sexagesimal positions #175

mwapst opened this issue Jun 27, 2024 · 2 comments · Fixed by #262
Assignees
Milestone

Comments

@mwapst
Copy link
Contributor

mwapst commented Jun 27, 2024

Currently shown as degrees, which apparently some databases use instead of time. Do we need a conversion tool between hh:mm:ss and degrees, which will probably have rounding errors, so need to think about comparison with other databases. Which one will we store?
Also, maybe allow user to enter either, then calculate and present the other on the ui too.

@pahjbo
Copy link
Member

pahjbo commented Jun 27, 2024

this is related to the library mentioned in #72 (comment) - so note the conversion should be done on the client side

@pahjbo pahjbo changed the title Right Ascension units Sexagesimal positions Jun 28, 2024
@pahjbo pahjbo added this to the Real Deployment milestone Jul 15, 2024
@Republicof1 Republicof1 self-assigned this Aug 21, 2024
@pahjbo pahjbo modified the milestones: Real Deployment, ADASS 2024 Sep 10, 2024
@Republicof1
Copy link
Contributor

Just to provide a quick update on this task.

I have been working with a fork on TSOFA, the transpiled TS version of the SOFA C library.
The key task was to make it a usable node package - which to a large extent it already was, albeit in a slightly awkward way. AstroLib is going be the much friendlier user layer package that allows us to convert to and from sexagesimal coordinates.

AstroLib is planned to be build on contemporary principles such as ECMA Script Modulse -ES Modules, or ESM for short. Working with TSOFA wasn't particularly harmonious as this was based on CommonJS. The documentation suggests that it is possible for these standards to interoperate, but in practice this is not ideal. As we contol the code for both TSOFA and AstroLib, it made reasonable sense to bring TSOFA up-to-date.

This work breaks into two tasks, 1. re-engineer TSOFA so that it is ESM compliant and (due it being built in TS) with build into JavaScript using TSC. 2. switch the testing fromework from TestyTS to the significantly better supported Jest.

I have now completed both of these tasks.

Remaining work on TSOFA:
Port the changes from my fork of TSOFA into the principle repo.
Update the CI script in the principle repo to be able to run Jest tests.
Update the private npm package on prime repo (via publish action).

Next tasks for this issue:
Implement Jest in AstroLib, including making some tests that will pass as the solution develops.
Build out functions in AstroLib that can be accessed within Polaris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants