Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of manual spec_file.rpm_dist configuration option providing #8

Open
esyr-rh opened this issue Nov 3, 2017 · 0 comments
Open

Comments

@esyr-rh
Copy link
Contributor

esyr-rh commented Nov 3, 2017

So far, it is used only for DD ISO filename generation and isn't employed in spec at all. Once we get the notion of distribution implemented that can provide this information as well, I see no reason to provide it in module.config at all.

The other related question is whether we need to enforce specific %dist tag and, more important, at which level.

orosp pushed a commit that referenced this issue Jan 15, 2019
* profiles/rh-release (spec_file.rpm_dist): Define to
"el{major}_{minor}".
* profiles/rh-testing (spec_file.rpm_dist): Likewise.
* templates/config: Add configuration options for major/minor.
* bin/ddiskit (parse_cli): Add options for setting major/minor in
prepare_sources command.
* ddiskit.1 (.SS Options for prepare_sources action): Document -M and -m
options.

References: #2
References: #8
Signed-off-by: Eugene Syromiatnikov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant