Travis for install script #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preliminary merge
Signed-off-by: Ruben Smits <[email protected]>
Signed-off-by: Ruben Smits <[email protected]>
Signed-off-by: Ruben Smits <[email protected]>
Signed-off-by: Ruben Smits <[email protected]>
Signed-off-by: Ruben Smits <[email protected]>
Signed-off-by: Ruben Smits <[email protected]>
meyerj
force-pushed
the
travis-for-install-script
branch
from
707f3c7 to
be98b08
Compare
Signed-off-by: Ruben Smits <[email protected]>
Signed-off-by: Ruben Smits <[email protected]>
meyerj
reviewed
Jan 16, 2017
.travis.yml
Outdated
| - if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then brew link --force gnu-getopt ; fi | ||
|
|
||
| script: | ||
| - ./install.sh --verbose --prefix $HOME/install --enable-tests --enable-corba --enable-mqueue |
There was a problem hiding this comment.
We don't actually run the tests, so why build them? Or should we add another line that runs the tests after installation? Or would you expect that --enable-tests not only builds but also runs the tests?
Signed-off-by: Ruben Smits <[email protected]>
Unit tests will be built and run for individual projects, but not for this meta repository. The purpose of this job is mainly to test the installation script.
|
Looks good to merge now. Note that containerized builds still cause some trouble for unit testing, like in orocos-toolchain/rtt#195, but as a pure installation script test case it should be fine. I disabled tests in 71d9b01, but they were only built and not executed until now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.