Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing method name in NSDate+OBAdditions #18

Open
rais38 opened this issue Oct 9, 2013 · 0 comments
Open

Confusing method name in NSDate+OBAdditions #18

rais38 opened this issue Oct 9, 2013 · 0 comments

Comments

@rais38
Copy link

rais38 commented Oct 9, 2013

+ (instancetype)date returns the current date and could be better rename the method - (NSUInteger)day to - (NSUInteger)today and the implementation of - (NSUInteger)day:

- (NSUInteger)day
{
    NSDateComponents *components = [[NSCalendar currentCalendar] components:NSDayCalendarUnit | NSMonthCalendarUnit | NSYearCalendarUnit fromDate:self];
    return [components day];
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant