fix: The remoteEntryChunk should use the base path from the Vite co…
#631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baijunjie
force-pushed
the
baijunjie/issue629
branch
from
987f451
to
56e73d4
Compare
baijunjie
force-pushed
the
baijunjie/issue629
branch
from
56e73d4
to
a913606
Compare
|
It seems that the CI didn't pass. Is there anything else you need me to do? |
|
It looks like the test fails, does it work locally for you? |
These errors don’t seem related to my changes. 
|
|
What is the hold up for this to get merged? I would really need this fix asap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nfig.
Fixes #629
Description
Under normal circumstances, the reference paths for resource files built by a plugin should align with the base path specified in the Vite config.
Additional context
The
filenameof the exposed remote module usually doesn't include a hash because it's the entry point for remote modules and needs to be accessible by external applications. Therefore, it is typically deployed separately on Nginx, while other resources are placed on a CDN. If a relative path is used, it can cause a bug where files can't be found.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).