Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with Vite #613

Open
jtan80813 opened this issue Jul 16, 2024 · 0 comments
Open

Bug with Vite #613

jtan80813 opened this issue Jul 16, 2024 · 0 comments

Comments

@jtan80813
Copy link

jtan80813 commented Jul 16, 2024

Versions

  • vite-plugin-federation:
  • vite:

Steps to reproduce

Try adding shared in vite.config.ts
Ex:

federation({
      name: "host-app",
      remotes: {
        remoteRemixApp: "http://localhost:3010/assets/remoteEntry.js",
      },
      shared: ["react", "react-dom"],
}),

What is Expected?

Should not output react-dom cannot be external

What is actually happening?

When building it, it errors out saying like Entry module "react-dom" cannot be external.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant