Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancements and Long/Short rest #195

Closed
RaphaelPage0110 opened this issue Dec 22, 2021 · 3 comments · Fixed by #217 or #241
Closed

Enhancements and Long/Short rest #195

RaphaelPage0110 opened this issue Dec 22, 2021 · 3 comments · Fixed by #217 or #241
Labels
bug Something isn't working enhancement New feature or request

Comments

@RaphaelPage0110
Copy link
Collaborator

RaphaelPage0110 commented Dec 22, 2021 •
edited
Loading

image
On this example, the enhancements are on the Skewer card...which you can not see from what we are displaying on the short and long rest pop-ups.

We should put them on the card...but that doesn't seem feasible. Since it isn't, we should not display the enhancement at all, similarily to the 'Abilities' and 'Enhancement' tab
@RaphaelPage0110 RaphaelPage0110 added bug Something isn't working enhancement New feature or request labels Dec 22, 2021
@orichalque
Copy link
Owner

maybe we could just not show the enhancements in these modals ?

@RaphaelPage0110
Copy link
Collaborator Author

Yep, that's what I said :D

@orichalque
Copy link
Owner

oops ^^'

@orichalque orichalque mentioned this issue Feb 28, 2022
Merged
@orichalque orichalque linked a pull request Feb 28, 2022 that will close this issue
[195] Removed enhancements in short and long rest modals #217
Merged
@orichalque orichalque linked a pull request Jan 26, 2023 that will close this issue
v5.7 #241
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@orichalque @RaphaelPage0110