Wallet pop up is overeager on requesting eth_accounts

[wengzilla]

Latest version of Phantom wallet is overeager to open. It's popping open anytime I request 'eth_accounts'. AFAIK, this is non-standard behavior and is highly disruptive. Metamask does not pop open.

const accounts = await window.ethereum.request({
   method: 'eth_accounts'
});

[adamdelphantom]

@wengzilla Do you have a hosted application where I can reproduce this? Also, what does the wallet render when it pops? A screenshot would be helpful. Thanks!

[wengzilla]

Yes, I understand that it pops when the setting is "Always Ask", but I'm not convinced that popping is the right behavior when a site is merely asking for the connected eth_accounts. As far as I can tell, Metamask does not pop open, so it's unclear why Phantom should.

Do you believe aggressively popping is the correct behavior? If so, does that mean you will not fix this issue?

[adamdelphantom]

My understanding is that with as support for eip3963 become pervasive, we will update this behavior. For the time being the responsiveness is necessary for Phantom users to be able to use Phantom with dApps that don't explicitly list Phantom as an option.

[wengzilla]

Can you link me to EIP-3963? I'm unable to find it and am not familiar with that proposal. Thanks!

Also, I do have other EVM-focused wallets and none of them seem to aggressively pop open on request eth_account. Do you know of any others with this type of behavior?

[adamdelphantom]

Apologies, I mistyped the proposal title. This is the proposal https://eips.ethereum.org/EIPS/eip-6963 and a reference implementation https://eip6963.org.

I haven't personally tested other wallets for this functionality.

[wengzilla]

It shouldn't pop at all... if you disable Phantom, you will recognize that Metamask doesn't pop on the same method call.

…

On Thu, Sep 21, 2023, 6:08 PM Adam ***@***.***> wrote: No, when I navigate to your app the wallet only pops once to connect and no other times. What browser/OS are you using? — Reply to this email directly, view it on GitHub <#103 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABVWKZJKVXAZ3VXKUFQRYTX3TQIRANCNFSM6AAAAAA47KOLHU> . You are receiving this because you were mentioned.Message ID: ***@***.***>