GitHub Community
Top level PR comment thread #8469
Replies: 23 comments 8 replies
-
|
Enabling threading on top level comments by default would be the biggest single improvement GitHub could make to Issue interaction. |
Beta Was this translation helpful? Give feedback.
-
|
Came looking for someone else saying this, and I'm sad to see the lack of traction it's gotten. This is absolutely my single biggest issue with using GitHub. I've taken to replying to top-level comments on PRs by @ing the person on slack, and attaching my own "top-level" comments to the first line of code. The alternative is to end up filling the PR with unresolvable top-level messages that could represent any number of discussions all mixed in with one another. It's a huge mess, and the excellent way comment threads in the actual code are handled shows that it doesn't need to be like that. |
Beta Was this translation helpful? Give feedback.
-
|
Please add this feature, it's very challenging when people leave questions or thoughts that need a response in top level comments. |
Beta Was this translation helpful? Give feedback.
-
|
This is wonderful idea. Would be happy to see it! |
Beta Was this translation helpful? Give feedback.
-
|
It would be very useful to have discussion threads on top level comments just like we have on file diffs. |
Beta Was this translation helpful? Give feedback.
-
|
I was working with GitLab very long in my previous position. Now moved to GitHub and im somehow shocked that this does not exist. Replying to a comment in a thread style is basically needed everywhere not just in top level RP comments. Its needed in issue comments as well. Please @github-staff have a look! 👀 |
Beta Was this translation helpful? Give feedback.
-
|
awesome, they're working really hard on it! github/roadmap#552 |
Beta Was this translation helpful? Give feedback.
-
|
2022 is about to end now, not sure if the feature can be shipped soon? |
Beta Was this translation helpful? Give feedback.
-
|
It looks like this was bumped to Q2 2023. |
Beta Was this translation helpful? Give feedback.
-
|
It seems it's been moved to "Future" now, so probably low priority. Too bad though, this feature would be great! |
Beta Was this translation helpful? Give feedback.
-
|
Does the feature mentioned apply only to pull requests, or does it also apply to issues? |
Beta Was this translation helpful? Give feedback.
-
|
FYI that roadmap item is now closed as not planned. "Replying to PR comments is currently in an exploratory phase, so we have removed it from this roadmap while we develop more definition and certainty on our scope and timelines." |
Beta Was this translation helpful? Give feedback.
-
|
Azure DevOps has this feature. Microsoft, please port it to GitHub. |
Beta Was this translation helpful? Give feedback.
-
|
Please add this feature. It really helps to make the PR comment view cleaner. It would also be nice for the "Require conversation resolution before merging" to (optionally) apply to top-level comments |
Beta Was this translation helpful? Give feedback.
-
|
Makes a lot of sense. Often need to provide more general comments, or alternatives that could be considered. |
Beta Was this translation helpful? Give feedback.
-
|
Please add this "feature" (seems more like a bug fix to me though). |
Beta Was this translation helpful? Give feedback.
-
|
So happy to see this on the road map. In addition to the problematic ability to follow the conversations of top level comments the tone of |
Beta Was this translation helpful? Give feedback.
-
|
I see that this issue was moved from Q2 2023 to the Future. What is the reasoning for this? |
Beta Was this translation helpful? Give feedback.
-
|
Please help to support this feature. In my current project, many people can put comments on the PR. It is too difficult to track all the comments and reply to them. |
Beta Was this translation helpful? Give feedback.
-
|
This feature available in gitlab, it so great, so please support add this feature to github. |
Beta Was this translation helpful? Give feedback.
-
|
We sometimes work around this by using file comments; slightly better than using line comments since it doesn't mislead the reader into thinking it's about a specific line of code. That workaround is super awkward though and I wish we didn't have to use it. |
Beta Was this translation helpful? Give feedback.
-
|
This will be an incredible feature, it exists in the discussions but we really need it in the pull requests! thanks github team :) |
Beta Was this translation helpful? Give feedback.
-
|
This is such a PITA for millons of developers on a daily basis. Why on earth is this not a thing yet? |
Beta Was this translation helpful? Give feedback.
-
|
coming from gitlab (which I'm used to having issues) I'm shocked it's had this feature for years whereas github still does not |
Beta Was this translation helpful? Give feedback.
-
|
+1 on this feature request! there are often more high level comments I want to make on PRs that dont relate to any specific piece of code. file level comments helps, but this would have been preferable |
Beta Was this translation helpful? Give feedback.
-
|
Hi everyone! We've created a free GitHub App + Action that enables threads on PR issue comments and can also be fully integrated with Slack. You can test it out in this PR. Demo.mp4@nickofthyme @christothes @usernamenumber @geoguide @hivokas @robnit @p0fi @mochadwi @SMR39 @bangank36 @Linths @richard-rance @ColbyODonnell @jdechicchis @eschapira-cs @dpirkle-naut @abrahamhunt @bautrey37 @rakusvn-ntdat @rakusvn-vmvuong @phoenixeliot @pierresisson @castagninojose @emplumb @hsorsky |
Beta Was this translation helpful? Give feedback.
-
|
Agreed with the others here that this is probably the simplest single improvement github could make to drastically improve the user experience for millions of developers. Feels like the stone ages quoting each other's previous comments and trying to piece together threads when multiple people are reviewing a PR. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
That's sad. |
Beta Was this translation helpful? Give feedback.
-
|
ugh whyyyy! It's such a basic feature |
Beta Was this translation helpful? Give feedback.
and others
-
I wish there was a way to create a thread on a top-level pull request review comments.
Often times I find I want to add a general comment that is not related to any specific line of code. For example, like elastic/elastic-charts#1475 (review). I have left comments on specific lines of code to be addressed but then I have a general comment on top of those.
The issue is, if this top-level comment is actionable such that I am requesting the author to change some code in a general sense or it might just be a general question that I would like a response to, there is not a great way to respond to this comment.
Currently, the best approach is something like elastic/elastic-charts#1475 (comment), where we use so called Quote reply via block-quotes (i.e.
>) to address each part of the top-level comment in a new top-level comment.The issue with this is that it creates a disconnect between the original comment and the response, as well as creating noise on the pr with several top-level comments. This issue is not as important with issues (non-prs) because the top-level is often a back and forth response with a single idea where there is not often tangential ideas/threads active at the same time, though could be useful in some cases.
An ideal solution would be to enable a thread for top-level pr review comments. Maybe by default it is as it is currently, but with an option to create a thread off of the comment.
Beta Was this translation helpful? Give feedback.
All reactions