How do we make sure all PR to a branch require 2 approvals from specific 2 users?

[0xdhrv]

Select Topic Area

Question

Body

How do we make sure all PR to a branch require 2 approvals from specific 2 users?

[mkmckenna]

To do this you need to configure some branch protection rules. One restriction you might face is the users will probably need to be classed as coder owners.

You'll need to require that branches can only be merged from a PR, and require a review from 2 code owners.

Setup Branch Protection Rule

• Within your repository go to Settings -> Branches -> Add Rule
• Enter the name of the branch you want to apply the rules to
• Under Protect matching branches select Require a pull request before merging and also Require approvals
• Use the dropdown on Require approvals and select 2
• Select Require review from Code Owners

Setup Code Owners

Once you've went through those steps you'll need to also drop a code owners file into your repo. Can you read a bit about that here: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

I think a basic template would be something like this

# Code owners for the entire repository
* @user1 @user2

Hope that helps

[ebndev]

Hi @mkmckenna, thanks for taking the time to answer!

@0xdhrv if the response above helped, please feel encouraged to mark it as the answer. If not, let us know if you have further questions 😄

[mkmckenna]

@0xdhrv - Did this answer solve your problem?

[RamonSouzaDev]

Did this answer solve your problem?

[0xdhrv]

Thanks for this. Is there a way to require two approvals from two different lists of people? For example:

First approval needed from: [John, Alice, ...]

Second approval needed from: [Steve, Emily, ...]

[github-actions[bot]]

🕒 Discussion Activity Reminder 🕒

This Discussion has been labeled as dormant by an automated system for having no activity in the last 60 days. Please consider one the following actions:

1️⃣ Close as Out of Date: If the topic is no longer relevant, close the Discussion as out of date at the bottom of the page.

2️⃣ Provide More Information: Share additional details or context — or let the community know if you've found a solution on your own.

3️⃣ Mark a Reply as Answer: If your question has been answered by a reply, mark the most helpful reply as the solution.

Note: This dormant notification will only apply to Discussions with the Question label. To learn more, see our recent announcement.

Thank you for helping bring this Discussion to a resolution! 💬

[github-actions[bot]]

🕒 Discussion Activity Reminder 🕒

This Discussion has been labeled as dormant by an automated system for having no activity in the last 60 days. Please consider one the following actions:

1️⃣ Close as Out of Date: If the topic is no longer relevant, close the Discussion as out of date at the bottom of the page.

2️⃣ Provide More Information: Share additional details or context — or let the community know if you've found a solution on your own.

3️⃣ Mark a Reply as Answer: If your question has been answered by a reply, mark the most helpful reply as the solution.

Note: This dormant notification will only apply to Discussions with the Question label. To learn more, see our recent announcement.

Thank you for helping bring this Discussion to a resolution! 💬

[0xdhrv]

Thanks for this. Is there a way to require two approvals from two different lists of people? For example:

First approval needed from: [John, Alice, ...]

Second approval needed from: [Steve, Emily, ...]