Marking comments as 'blocking' or 'non-blocking' #113543
Unanswered
MFAshby
asked this question in
Pull Requests
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Select Topic Area
Product Feedback
Body
I review a lot of Pull Requests. I often leave comments which are purely stylistic improvements, minor questions,or positive feedback, and these comments should not block a pull request from being merged. I also leave a lot of comments which must be addressed before merging.
At the moment we have a setting to not allow PRs to merge with unresolved comments. This isn't granular enough for me, I would prefer to indicate which comments should and should not prevent merging, otherwise I have to resolve a lot of non-blocking comments prior to allowing a merge (we have a general rule that you should only resolve your own comments)
Thanks!
Beta Was this translation helpful? Give feedback.
All reactions