Ability to track what changes were reviewed

[IDrumsey]

Select Topic Area

Product Feedback

Body

It's hard to keep track of what exact changes have been reviewed throughout the lifecycle of reviewing a PR. This is because there is no option to track which lines have been reviewed. Here's an example of the problem.

Person A opens a PR with 1 file changed. There are a lot of changes in that file.

Person A requests Person B to review.

Person B opens the file changes and starts reviewing at the top of the file.

Person B reaches a bug that they feel would be better to get addressed before they continue on with their review. They don't mark the file as viewed, because they didn't review all the changes in the file. They submit the review asking Person A to make the change.

A week goes by...

Person A makes the change and re-requests a review from Person B.

Person B opens the file changes from all commits.

The indication Changed since last view appears on the file.

Person B applies the filter "Changes since last review" under the false assumption that they reviewed all the changes from previous commits forgetting that they actually didn't.

Person B approves the review and the changes get merged in.

The problem here is that Person B totally missed reviewing a large amount of changes.

One solution is to give the reviewer the ability to mark off (for each review they start) which lines they reviewed. I don't know exactly what this would look like, but here's one idea.

1. Reviewer has a reviewed checkbox next to each line during a review. On follow up reviews, there is some sort of UI that shows the previous review's reviewed lines. If they're all reviewed, then the user knows that they're ok to filter commits to just commits since the last review for that file. Could even have a little alert that shows on the file saying "All changes reviewed up to last review" if all the lines in a file have been marked as reviewed for each previous review.

Maybe teams have come up with standards to get around this problem. idk.

Or is it just a standard that you review every change before you submit a review, that way the next review you do, you are safe to assume you have reviewed all previous changes.

Another thing is if you use the "Viewed" checkbox on the file to indicate that you reviewed all changes, then you run into the problem of that checkmark automatically being removed when new changes are added to the file. Then you're back at square one not knowing how much you got through.