Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated readme.md #33

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

Ashimgautam356
Copy link
Contributor

@Ashimgautam356 Ashimgautam356 commented Oct 11, 2023

Description

Changes Made

Related Issues

Checklist

  • [ ✔️] I have tested these changes locally.
  • [ ✔️] I have added/updated documentation as needed.
  • [✔️ ] I have reviewed my code for potential issues.
  • [✔️ ] I have followed the project's coding guidelines.
  • [✔️ ] I have updated relevant comments and commit messages.

Screenshots (if applicable)

Additional Information

Reviewer Request

By submitting this PR, I confirm that:

  • [✔️ ] I have read and understood the project's contributing guidelines.
  • [✔️ ] This PR is ready for review and merging.
  • [✔️ ] I understand that automated tests should pass before merging.

@pfieffer
Copy link
Contributor

pfieffer commented Oct 15, 2023

Hey @Ashimgautam356
The actual implementation is correct
However can you please squash your three commits into one and then resolve conflict with org45:main branch and then push changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants