-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support reading credentials from docker credential store #47
Comments
The .NET SDK's built-in container tooling uses https://github.com/mthalman/docker-creds-provider to obtain credentials from these stores. The credentials are then used by this DelegatingHandler: https://github.com/dotnet/sdk/blob/main/src/Containers/Microsoft.NET.Build.Containers/AuthHandshakeMessageHandler.cs to set appropriate headers. @shizhMSFT what do you think about adopting a similar implementation? |
Thank @tmds for mentioning this SDK. I took a look at https://github.com/mthalman/docker-creds-provider. It provides the functionality of reading credentials (i.e. the read path) by properly following the docker credential helper protocol. However, it does not provide any operations for write paths. In other words, we are unable to implement Login and Logout using this SDK. |
I think we can start with this SDK by wrapping it. Then replace with our own implementation when we do need the write paths. |
Also interesting in this context: the SDK implements the "insecure" option with this https://github.com/dotnet/sdk/blob/main/src/Containers/Microsoft.NET.Build.Containers/FallbackToHttpMessageHandler.cs. https://github.com/dotnet/sdk/blob/main/src/Containers/Microsoft.NET.Build.Containers/Registry/DefaultRegistryAPI.cs is where these pieces are assembled into an I see there is a If you are open to external contributions, I can look at implementing a |
No description provided.
The text was updated successfully, but these errors were encountered: