Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

published source jar lacks Java sources #131

Open
ben-manes opened this issue Nov 20, 2024 · 1 comment
Open

published source jar lacks Java sources #131

ben-manes opened this issue Nov 20, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ben-manes
Copy link
Contributor

ben-manes commented Nov 20, 2024

Describe the bug
The releases on Maven Central include a -source jar which should allow an IDE to open the class sources if available. It appears that this may have been unintentionally lost when modifying the build, likely in Bug 35429969 - [35265307->23.09] Some of the coherence jars in latest patch are missing manifest file entries when the maven-jar-plugin configuration is overridden.

To Reproduce

$ wget https://repo1.maven.org/maven2/com/oracle/coherence/ce/coherence/24.09/coherence-24.09-sources.jar
$ jar -tf coherence-24.09-sources.jar
META-INF/
META-INF/MANIFEST.MF
META-INF/versions/
META-INF/versions/21/
META-INF/versions/21/META-INF/
META-INF/versions/21/com/
META-INF/versions/21/com/tangosol/
META-INF/versions/21/com/tangosol/internal/
META-INF/versions/21/com/tangosol/internal/util/
META-INF/maven/
META-INF/maven/com.oracle.coherence.ce/
META-INF/maven/com.oracle.coherence.ce/coherence/
META-INF/versions/21/META-INF/LICENSE.txt
META-INF/versions/21/META-INF/THIRD_PARTY_LICENSES.txt
META-INF/versions/21/com/tangosol/internal/util/ExceptionHelper.class
META-INF/versions/21/com/tangosol/internal/util/VirtualThreads.class
META-INF/maven/com.oracle.coherence.ce/coherence/pom.xml
META-INF/maven/com.oracle.coherence.ce/coherence/pom.properties

Expected behaviour

$ wget https://repo1.maven.org/maven2/com/oracle/coherence/ce/coherence/23.03.1/coherence-23.03.1-sources.jar
$ jar -tf coherence-23.03.1-sources.jar | grep \\.java | head
com/oracle/coherence/persistence/PersistenceException.java
com/oracle/coherence/persistence/PersistenceTools.java
com/oracle/coherence/persistence/PersistenceStatistics.java
com/oracle/coherence/persistence/PersistenceManager.java
com/oracle/coherence/persistence/package-info.java
com/oracle/coherence/persistence/PersistenceEnvironment.java
com/oracle/coherence/persistence/ConcurrentAccessException.java
com/oracle/coherence/persistence/OfflinePersistenceInfo.java
com/oracle/coherence/persistence/FatalAccessException.java
com/oracle/coherence/persistence/AsyncPersistenceException.java

Screenshots
Screenshot 2024-11-19 at 5 56 19 PM

@ben-manes ben-manes added the bug Something isn't working label Nov 20, 2024
@aseovic
Copy link
Member

aseovic commented Nov 20, 2024

Damn... Thanks for reporting this. Not much we can do about stuff that's already published, but we'll make sure it's fixed in the next patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants