Feature/ker/basic zmq rpc #2
Conversation
keriksson-rosenqvist
requested review from
jfriel-oqc,
owen-oqc,
hamidelmaazouz and
chemix-lunacy
as code owners
| raise ValueError(f"No such file: {calibration_file}") | ||
| log.info(f"Loading: {calibration_file} ") | ||
| hw = Calibratable.load_calibration_from_file(str(calibration_file)) | ||
| log.debug("Loaded") |
There was a problem hiding this comment.
@keriksson-rosenqvist Consider a context here like we do for reporting time metrics in QAT
|
CLA Assistant Lite bot All Contributors have signed the CLA. |
|
I have read the Contributor License Agreement and I hereby accept the Terms. |
| raise ValueError(f"No such file: {calibration_file}") | ||
| log.info(f"Loading: {calibration_file} ") | ||
| hw = Calibratable.load_calibration_from_file(str(calibration_file)) | ||
| log.debug("Loaded") |
There was a problem hiding this comment.
@keriksson-rosenqvist Consider a context here like we do for reporting time metrics in QAT
|
|
||
|
|
||
| parser = argparse.ArgumentParser(prog="QAT submission service", description="Submit your QASM or QIR program to QAT.") | ||
| parser.add_argument("program", type=str, help="Program string or path to program file.") |
There was a problem hiding this comment.
I presume program doesn't need a flag here right ? sth like runner --config <config> <program> ?
|
|
||
| @property | ||
| def address(self): | ||
| return f"{self._protocol}://{self._ip_address}:{self._port}" |
There was a problem hiding this comment.
minor: would've leaned on the URL/URI structures here
| def address(self): | ||
| return f"{self._protocol}://{self._ip_address}:{self._port}" | ||
|
|
||
| def _check_recieved(self): |
There was a problem hiding this comment.
you probably also want a retry mechanism here similar to _send() ?
| thread01 = threading.Thread( | ||
| target=execute_and_check_result, | ||
| args=(client0, program, config0, {"c": { "00": 100}}), | ||
| ) |
There was a problem hiding this comment.
any thoughts how useful would a thread pool be ? to easily scale the number of threads and stress test the clients ?
| @@ -19,6 +24,9 @@ optional = true | |||
| [tool.poetry.group.licenses.dependencies] | |||
| pip-licenses = "^3.5.3" | |||
|
|
|||
| [tool.poetry.scripts] | |||
| qat_comexe="qat_rpc.zmq.qat_commands:qat_run" | |||
There was a problem hiding this comment.
not the most intuitive name ^^, would've called it qat_run ^^
Simple ZMQ implementation of RPC.