Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change QAT dependency from ^2.3.0 to ^2.3 #15

Closed
wants to merge 1 commit into from

Conversation

matt-oqc
Copy link
Collaborator

@matt-oqc matt-oqc commented Nov 27, 2024

This change will allow the qat-compiler version dependency to update in the range >= v2.3.0, < 3.0.0.

@keriksson-rosenqvist
Copy link
Contributor

Are you sure you want to do this? While there shouldn't be any breaking changes in the surface API there may be cause for making a new minor version what QAT or Whisqrs make one. 🤔

@keriksson-rosenqvist
Copy link
Contributor

Also, the change is not needed. ^2.3.0 and ^2.3 are equivalent
https://python-poetry.org/docs/dependency-specification/

@matt-oqc matt-oqc closed this Nov 28, 2024
@matt-oqc matt-oqc deleted the build/mh/qat-dependency-change branch November 28, 2024 12:41
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants