Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Carsons models to avoid double class creation #30

Open
etimberg opened this issue Aug 26, 2019 · 0 comments
Open

Refactor Carsons models to avoid double class creation #30

etimberg opened this issue Aug 26, 2019 · 0 comments
Assignees

Comments

@etimberg
Copy link
Contributor

The CarsonsEquations model class is instantiated from another object that contains the necessary attributes. This poses a problem when you want to run Carson's equations on some values as you need to create a shim class to pass those values to the model.

Some ideas for improving this

  • add property names in __init__ instead of a plain model
  • keep the model and replace with a dictionary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants