Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Consider moving from Newtonsoft to System.Text.Json #373

Open
nuttytree opened this issue Oct 2, 2024 · 4 comments
Open

Comments

@nuttytree
Copy link

Description

In general it seems most major libraries are moving way from Newtonsoft to System.Text.Json. It would be good to see this library do the same.

Benefits

System.Text.Json seems to be the future of JSON parsing in .NET and is faster than Newtonsoft.

Detail

No response

Examples

No response

Risks/Downsides

No response

@nuttytree
Copy link
Author

I did a little digging into this. For .NET 3.5/4.0 and .NET Standard 1.6 using System.Text.Json is not an option. However with a bit of conditional code it would be pretty easy and straightforward to switch .NET Standard 2.0 to System.Text.Json. Would you be open to me putting up a PR to make the change?

@mikechu-optimizely
Copy link
Contributor

Holy smokes. This Issue didn't ping my radar. @nuttytree I'm genuinely sorry about that.

Did you find your solution yet? We're always open to a PR which helps us understand your problem and solution space effectively.

Note: We have on our roadmap to review and potentially deprecate end of life versions and move towards Core.

@nuttytree
Copy link
Author

Not a big deal, we are trying to move away from Newtonsoft in general and this NuGet is one of the big sources of it getting pulled in for us. I will try and get a PR up in the next month or so, I just didn't want to do the work if it wouldn't get accepted.

@mikechu-optimizely
Copy link
Contributor

Totally understand. Modernization is on our horizon too.

I've created internal work item FSSDK-11026 to track this Issue/PR.

Thanks much for the collab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants